[ 
https://issues.apache.org/jira/browse/HBASE-19369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271728#comment-16271728
 ] 

Appy commented on HBASE-19369:
------------------------------

Please add a code comment explaining why we build output stream two different 
ways. (code readability) 
On you commit message, what kind of feedback are we looking for here? Any test 
that was failing earlier but passes now? What's your plan of testing this?

> HBase Should use Builder Pattern to Create Log Files while using WAL on 
> Erasure Coding
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-19369
>                 URL: https://issues.apache.org/jira/browse/HBASE-19369
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Alex Leblang
>            Assignee: Alex Leblang
>         Attachments: HBASE-19369.master.001.patch
>
>
> Right now an HBase instance using the WAL won't function properly in an 
> Erasure Coded environment. We should change the following line to use the 
> hdfs.DistributedFileSystem builder pattern 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java#L92



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to