[ 
https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279040#comment-16279040
 ] 

Appy commented on HBASE-19417:
------------------------------

bq. The hooks reference familyPaths which is computed in non-secure bulk load 
case.
Is there a reason why it's not computed for secure case? If not, should be easy?

bq. Clarification: for secureBulkLoadManager case, the absence of hook calls 
was there before HBASE-17123
Most probably a prior bug. Then this jira is fixing more than we expected. 
great.

> Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
> ------------------------------------------------------------
>
>                 Key: HBASE-19417
>                 URL: https://issues.apache.org/jira/browse/HBASE-19417
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Ted Yu
>         Attachments: 19417.v1.txt, 19417.v2.txt, 19417.v3.txt, 19417.v4.txt, 
> 19417.v5.txt, 19417.v6.txt
>
>
> See the discussion at the tail of HBASE-17123 where Appy pointed out that the 
> override of loaded should be placed inside else block:
> {code}
>       } else {
>         // secure bulk load
>         map = regionServer.secureBulkLoadManager.secureBulkLoadHFiles(region, 
> request);
>       }
>       BulkLoadHFileResponse.Builder builder = 
> BulkLoadHFileResponse.newBuilder();
>       if (map != null) {
>         loaded = true;
>       }
> {code}
> This issue is to address the review comment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to