[
https://issues.apache.org/jira/browse/HBASE-5259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195183#comment-13195183
]
Hadoop QA commented on HBASE-5259:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12512226/HBASE-5259.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -140 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 161 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
org.apache.hadoop.hbase.io.hfile.TestHFileBlock
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/859//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/859//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/859//console
This message is automatically generated.
> Normalize the RegionLocation in TableInputFormat by the reverse DNS lookup.
> ---------------------------------------------------------------------------
>
> Key: HBASE-5259
> URL: https://issues.apache.org/jira/browse/HBASE-5259
> Project: HBase
> Issue Type: Improvement
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D1413.1.patch, D1413.1.patch, D1413.1.patch,
> D1413.1.patch, D1413.2.patch, D1413.2.patch, D1413.2.patch, D1413.2.patch,
> D1413.3.patch, D1413.3.patch, D1413.3.patch, D1413.3.patch, HBASE-5259.patch
>
>
> Assuming the HBase and MapReduce running in the same cluster, the
> TableInputFormat is to override the split function which divides all the
> regions from one particular table into a series of mapper tasks. So each
> mapper task can process a region or one part of a region. Ideally, the mapper
> task should run on the same machine on which the region server hosts the
> corresponding region. That's the motivation that the TableInputFormat sets
> the RegionLocation so that the MapReduce framework can respect the node
> locality.
> The code simply set the host name of the region server as the
> HRegionLocation. However, the host name of the region server may have
> different format with the host name of the task tracker (Mapper task). The
> task tracker always gets its hostname by the reverse DNS lookup. And the DNS
> service may return different host name format. For example, the host name of
> the region server is correctly set as a.b.c.d while the reverse DNS lookup
> may return a.b.c.d. (With an additional doc in the end).
> So the solution is to set the RegionLocation by the reverse DNS lookup as
> well. No matter what host name format the DNS system is using, the
> TableInputFormat has the responsibility to keep the consistent host name
> format with the MapReduce framework.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
