[ 
https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195437#comment-13195437
 ] 

Phabricator commented on HBASE-5297:
------------------------------------

tedyu has commented on the revision "HBASE-5297 [jira] Update metrics 
numOpenConnections and callQueueLen directly in HBaseServer".

  Haven't figured out why there were extra failed tests reported by Hadoop QA 
for patch v2.
  On my MacBook, the following tests passed (last command looped 
TestAtomicOperation 4 times):
    558  mt -Dtest=TestAtomicOperation
    559  mt -Dtest=TestLruBlockCache
    561  ~/runtest.sh 4 TestAtomicOperation

REVISION DETAIL
  https://reviews.facebook.net/D1509

                
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5297
>                 URL: https://issues.apache.org/jira/browse/HBASE-5297
>             Project: HBase
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch, 
> HBASE-5297.D1509.3.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that 
> HBaseRpcMetrics doesn't have to hold reference to HBaseServer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to