[ 
https://issues.apache.org/jira/browse/HBASE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197670#comment-13197670
 ] 

Alexey Zotov commented on HBASE-1621:
-------------------------------------

We use merge_online.rb script. It has a small bug.

When we start script in dry-run mode (without "-n" option) it creates empty 
directories in HDFS:
{code}
0           
hdfs://<HOSTNAME>/hbase/<TABLE_NAME>/0d5a0784d3ce2450ce1936efe3d0232a
1975581     
hdfs://<HOSTNAME>/hbase/<TABLE_NAME>/2005c8cfd13b48bda6fb7faaacaf8cd4
0           
hdfs://<HOSTNAME>/hbase/<TABLE_NAME>/45b75d9c4cc1bbef6dec0326a8bc42a1
1941609     
hdfs://<HOSTNAME>/hbase/<TABLE_NAME>/66c227828b9404762cea8f7d8890957c
0           
hdfs://<HOSTNAME>/hbase/<TABLE_NAME>/7cc710a1ef01dd5c4805bb8b4ee9f79b
0           
hdfs://<HOSTNAME>/hbase/<TABLE_NAME>/a0f510e86fcc69fbacae68536dd496ae
1905306     
hdfs://<HOSTNAME>/hbase/<TABLE_NAME>/dc9ca1251fd4f1a48392b37c7a7c2fcc
1971976     
hdfs://<HOSTNAME>/hbase/<TABLE_NAME>/f4bfae7e508ca852f54806d954f49029
{code}

We've created the patch:
{code}
--- online_merge.rb     2012-02-01 00:11:25.000000000 -0800
+++ online_merge_fixed.rb       2012-02-01 00:11:14.000000000 -0800
@@ -266,7 +266,7 @@
 
   # For each family, move all the files one by one
   for family in tableDesc.getFamiliesKeys
-    HRegion.makeColumnFamilyDirs(fs, tableDir, newHRI, family)
+    HRegion.makeColumnFamilyDirs(fs, tableDir, newHRI, family) if normalRun
     newFamilyPath = Store.getStoreHomedir(tableDir, newHRI.getEncodedName, 
family)
     
     for row in toMerge
{code}

                
> merge tool should work on online cluster, but disabled table
> ------------------------------------------------------------
>
>                 Key: HBASE-1621
>                 URL: https://issues.apache.org/jira/browse/HBASE-1621
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ryan rawson
>            Assignee: stack
>             Fix For: 0.94.0
>
>         Attachments: 1621-trunk.txt, HBASE-1621-v2.patch, HBASE-1621.patch, 
> hbase-onlinemerge.patch, online_merge.rb
>
>
> taking down the entire cluster to merge 2 regions is a pain, i dont see why 
> the table or regions specifically couldnt be taken offline, then merged then 
> brought back up.
> this might need a new API to the regionservers so they can take direction 
> from not just the master.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to