[
https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302124#comment-16302124
]
Appy edited comment on HBASE-10092 at 12/23/17 12:08 AM:
---------------------------------------------------------
bq. So now this script will output a lot more log messaging? We don't have the
debug flag to turn off the verboseness of zk logger now, so we will always get
lots of messages? I haven't tried this yet, so maybe I'm misunderstanding the
change.
You're right, lot more logging. Root cause is, slf4j.Logger has no setLevel
function. That's the price we are paying to move away from dead dep by just
changing frontend.
In RB, i have a couple comments where we are removing this from java files. I
didn't really care those removals from tests, but tools seemed important,
however not important enough to block the whole move away from dead dep.
was (Author: appy):
bq. So now this script will output a lot more log messaging? We don't have the
debug flag to turn off the verboseness of zk logger now, so we will always get
lots of messages? I haven't tried this yet, so maybe I'm misunderstanding the
change.
You're right, lot more logging. Root cause is, slf4j.Logger has no setLevel
function. That's the price we are paying to move away from dead dep in a
half-measures way.
In RB, i have a couple comments where we are removing this from java files. I
didn't really care those removals from tests, but tools seemed important,
however not important enough to block this.
> Move to slf4j
> -------------
>
> Key: HBASE-10092
> URL: https://issues.apache.org/jira/browse/HBASE-10092
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Balazs Meszaros
> Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 10092.txt, 10092v2.txt,
> HBASE-10092-addendum-2.master.002.patch, HBASE-10092-addendum.patch,
> HBASE-10092-preview-v0.patch, HBASE-10092.master.001.patch,
> HBASE-10092.master.002.patch, HBASE-10092.master.003.patch,
> HBASE-10092.master.004.patch, HBASE-10092.patch
>
>
> Allows logging with less friction. See http://logging.apache.org/log4j/2.x/
> This rather radical transition can be done w/ minor change given they have an
> adapter for apache's logging, the one we use. They also have and adapter for
> slf4j so we likely can remove at least some of the 4 versions of this module
> our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency
> resolve hell courtesy of our slf4j. Fixing will take some concentration and
> a good net connection, an item I currently lack. Other TODOs are that will
> need to fix our little log level setting jsp page -- will likely have to undo
> our use of hadoop's tool here -- and the config system changes a little.
> I will return to this project soon. Will bring numbers.
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
