[ 
https://issues.apache.org/jira/browse/HBASE-19457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303992#comment-16303992
 ] 

Appy commented on HBASE-19457:
------------------------------

Fixed now. But quoting the comment from other jira 
(https://issues.apache.org/jira/browse/HBASE-19530?focusedCommentId=16293663&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16293663).

{quote}
Btw, i predict that this patch might make "fix" TestTruncateTableProcedure.
I quote fix because, those failures are result of two assumption collectively 
resulting in a failure (region state = null --> assume OFFLINE, table state = 
null --> assume ENABLED).
This will break the first one and test might start passing.
But we still need to address the second one, and that will be done in 
HBASE-19529.
{quote}

Closing this one.

> Debugging flaky 
> TestTruncateTableProcedure#testRecoveryAndDoubleExecutionPreserveSplits
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-19457
>                 URL: https://issues.apache.org/jira/browse/HBASE-19457
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-19457.master.001.patch, patch1, test-output.txt
>
>
> Trying to explain the bug in a more general way where understanding of 
> ProcedureV2 is not required.
> Truncating table operation:
> ....
> delete region states from meta
> delete table state from meta
> ....
> add new regions to meta with state null.
> ....crash
> ....recovery: TableStateManager treats table with null state as ENABLED. AM 
> treats regions with null state as offline. Combined result - AM starts 
> assigning the new regions from incomplete truncate operation.
> Fix: Mark table as disabled instead of deleting it's state.
> ----
> *patch1*
> Just added some logging to help with debugging:
> - 60s was too less time, increased timeout
> - Added some useful log statements



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to