[ https://issues.apache.org/jira/browse/HBASE-19672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiang Li updated HBASE-19672: ----------------------------- Attachment: HBASE-19672.master.000.patch Upload patch 000 to add \{@link\} > Correct comments for default values of major compaction in > SortedCompactionPolicy#getNextMajorCompactTime() > ----------------------------------------------------------------------------------------------------------- > > Key: HBASE-19672 > URL: https://issues.apache.org/jira/browse/HBASE-19672 > Project: HBase > Issue Type: Bug > Reporter: Xiang Li > Priority: Minor > Attachments: HBASE-19672.master.000.patch > > > {code:title=hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java|borderStyle=solid} > public long getNextMajorCompactTime(Collection<HStoreFile> filesToCompact) { > { > // default = 24hrs > long period = comConf.getMajorCompactionPeriod(); > ... > // default = 20% = +/- 4.8 hrs > double jitterPct = comConf.getMajorCompactionJitter(); > ... > } > {code} > If I get it correctly, currently, default major compaction period is 7 > days,and jitter is 0.5, so 3.5 days. > We could either remove those comments, or add \{@link\} to link to the > default value definitions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)