[
https://issues.apache.org/jira/browse/HBASE-19478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307253#comment-16307253
]
Ted Yu commented on HBASE-19478:
--------------------------------
{code}
+ * Check if WAL file is eligible for deletion Future using multi-get
{code}
It seems 'Future' is not needed in above sentence.
{code}
+ public Map<FileStatus, Boolean> isWALFilesDeletable(Iterable<FileStatus>
files) throws IOException {
{code}
For WALFiles, 'are' should be used - areWALFilesDeletable().
w.r.t. meaning of values in its returned Map, since you have this in the caller:
{code}
+ boolean logInSystemTable = entry.getValue();
{code}
please modify the javadoc to match the actual meaning.
> Utilize multi-get to speed up WAL file checking in BackupLogCleaner
> -------------------------------------------------------------------
>
> Key: HBASE-19478
> URL: https://issues.apache.org/jira/browse/HBASE-19478
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Toshihiro Suzuki
> Attachments: HBASE-19478.patch
>
>
> Currently BackupLogCleaner#getDeletableFiles() issues one Get per WAL file:
> {code}
> for (FileStatus file : files) {
> String wal = file.getPath().toString();
> boolean logInSystemTable = table.isWALFileDeletable(wal);
> {code}
> This is rather inefficient considering the number of WAL files in production
> can get quite large.
> We should use multi-get to reduce the number of calls to backup table (which
> normally resides on another server).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
