[ 
https://issues.apache.org/jira/browse/HBASE-19369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307604#comment-16307604
 ] 

Duo Zhang commented on HBASE-19369:
-----------------------------------

{quote}
hflush() and hsync() on DFSStripedOutputStream are no-op. Thus calling hflush() 
or hsync() on an erasure coded file can not guarantee data being persistent.
{quote}

This is enough to say that WAL can not use it. We need to make sure the data is 
persistent, then we can return success to user.

> HBase Should use Builder Pattern to Create Log Files while using WAL on 
> Erasure Coding
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-19369
>                 URL: https://issues.apache.org/jira/browse/HBASE-19369
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Alex Leblang
>            Assignee: Alex Leblang
>         Attachments: HBASE-19369.master.001.patch, 
> HBASE-19369.master.002.patch, HBASE-19369.master.003.patch, 
> HBASE-19369.master.004.patch, HBASE-19369.v5.patch, HBASE-19369.v6.patch, 
> HBASE-19369.v7.patch, HBASE-19369.v8.patch
>
>
> Right now an HBase instance using the WAL won't function properly in an 
> Erasure Coded environment. We should change the following line to use the 
> hdfs.DistributedFileSystem builder pattern 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java#L92



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to