[
https://issues.apache.org/jira/browse/HBASE-19733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317890#comment-16317890
]
Duo Zhang commented on HBASE-19733:
-----------------------------------
Just saw the patch, at least you should add a comment to say why you introduce
this shit code? And your IDE do not give you a warning on that 'stopped =
stopped' line?
I think this is better?
{code}
while (!stopped) {
if (!processor.process(inputProtocol, outputProtocol)) {
break;
}
}
{code}
> Fix checkstyle error in hbase-thrift module
> -------------------------------------------
>
> Key: HBASE-19733
> URL: https://issues.apache.org/jira/browse/HBASE-19733
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 19733.txt
>
>
> Currently build is failing
> (https://builds.apache.org/job/HBase-TRUNK_matrix/4363/jdk=JDK%201.8%20(latest),label=(Hadoop%20&&%20!H5)/console)
> due to:
> {code}
> [ERROR]
> src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java:[291,78]
> (blocks) EmptyBlock: Must have at least one statement.
> ...
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on
> project hbase-thrift: You have 1 Checkstyle violation. -> [Help 1]
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
