[
https://issues.apache.org/jira/browse/HBASE-19703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322049#comment-16322049
]
Anoop Sam John commented on HBASE-19703:
----------------------------------------
@param familyName
- * @return whether to skip the StoreFile range check or not
Removed the duplicated line. But it would be better u remove the top line.
Better to write @return after @param
Can we add a null check in RegionSplitPolicy? If null it lets throw an
IllegalStateException? That means the API been called not at the RS.
Pls add some comments around this null and also at HM side where we create this
newly. That why so and why created with out even a Region.
> Functionality added as part of HBASE-12583 is not working after moving the
> split code to master
> -----------------------------------------------------------------------------------------------
>
> Key: HBASE-19703
> URL: https://issues.apache.org/jira/browse/HBASE-19703
> Project: HBase
> Issue Type: Bug
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19703-WIP.patch, HBASE-19703_v2.patch
>
>
> As part of HBASE-12583 we are passing split policy to
> HRegionFileSystem#splitStoreFile so that we can allow to create reference
> files even the split key is out of HFile key range. This is needed for Local
> Indexing implementation in Phoenix. But now after moving the split code to
> master just passing null for split policy.
> {noformat}
> final String familyName = Bytes.toString(family);
> final Path path_first =
> regionFs.splitStoreFile(this.daughter_1_RI, familyName, sf, splitRow,
> false, null);
> final Path path_second =
> regionFs.splitStoreFile(this.daughter_2_RI, familyName, sf, splitRow,
> true, null);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
