[ https://issues.apache.org/jira/browse/HBASE-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200459#comment-13200459 ]
Doug Meil commented on HBASE-5330: ---------------------------------- Thanks Nicholas. I'll give #1 and #2 a shot. Especially for #3, the reason I was adding to the tests in the first place was to describe "what is happening" as opposed to "what should be happening." Basically, I want to get a better description of compaction in the book, so I figured that the unit tests were the best place to start. > TestCompactSelection - adding 2 test cases to testCompactionRatio > ----------------------------------------------------------------- > > Key: HBASE-5330 > URL: https://issues.apache.org/jira/browse/HBASE-5330 > Project: HBase > Issue Type: Improvement > Reporter: Doug Meil > Assignee: Doug Meil > Priority: Minor > Attachments: TestCompactSelection_hbase_5330.java.patch > > > There were three existing assertions in TestCompactSelection > testCompactionRatio that did "max # of files" assertions... > {code} > assertEquals(maxFiles, > > store.compactSelection(sfCreate(7,6,5,4,3,2,1)).getFilesToCompact().size()); > {code} > ... and for references ... > {code} > assertEquals(maxFiles, > store.compactSelection(sfCreate(true, > 7,6,5,4,3,2,1)).getFilesToCompact().size()); > {code} > > ... but they didn't assert against which StoreFiles got selected. While the > number of StoreFiles is the same, the files selected are actually different, > and I thought that there should be explicit assertions showing that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira