[ 
https://issues.apache.org/jira/browse/HBASE-19772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325336#comment-16325336
 ] 

stack commented on HBASE-19772:
-------------------------------

I ran w/o the patch on clean gce instance. No hangs. Added patch and runs 
promptly w/ no hangs.

We remove the wait on connect. Means that if we go to use an unconnected zk, 
our Task will fail. I was trying to figure how we might wait on the connected 
event coming in on a watcher before progressing -- perhaps passing it in as a 
Task -- but didn't get anywhere.

I'd be +1 for pushing this. Its needed. Can see if we get examples of usage w/o 
zk being connected.


> Do not close connection to zk when there are still pending request in 
> ReadOnlyZKClient
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-19772
>                 URL: https://issues.apache.org/jira/browse/HBASE-19772
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Zookeeper
>            Reporter: stack
>            Assignee: Duo Zhang
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19772-v2.patch, HBASE-19772.master.001.patch
>
>
> Here is [~Apache9] 's patch from the parent so it applies on top of what was 
> committed in the parent.
> Patch makes it so we we don't close out zk if available Tasks to run and 
> nicer logging.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to