[ 
https://issues.apache.org/jira/browse/HBASE-19797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326075#comment-16326075
 ] 

Duo Zhang commented on HBASE-19797:
-----------------------------------

A trivial change. Let me commit. Thanks [~zyork] for reviewing.

> Operator priority leads to wrong logic in ReplicationSourceWALReader
> --------------------------------------------------------------------
>
>                 Key: HBASE-19797
>                 URL: https://issues.apache.org/jira/browse/HBASE-19797
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19797.patch
>
>
> {code}
> if (e instanceof EOFException ||
>         e.getCause() instanceof EOFException && logQueue.size() > 1 && 
> this.eofAutoRecovery)
> {code}
> https://docs.oracle.com/javase/tutorial/java/nutsandbolts/operators.html
> According to the doc here, && has a higher priority than ||, so we will only 
> check logQueueSize when e.getCause is an EOFException, which is incorrect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to