[jira] [Commented] (HBASE-19770) `list` shell command does not return an array of table names

[Appy (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-19770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327622#comment-16327622
 ] 

Appy commented on HBASE-19770:
------------------------------

Fix versions for  HBASE-15965 was 1.4.0 and 2.0.0, so we should make this 
change in branch-1, branch-2, and master at least. Maybe in 1.4.x too?

The change is not enabling return-values by default when shell is started in 
non-interactive mode. Currently, '-n' is useless without '-r'. Shouldn't we set 
return_value=true for "--noninteractive" arg case too?

nit: reverse the condition?
{noformat}
+      if not return_values
         return nil
       else
         return ret
{noformat}

> `list` shell command does not return an array of table names
> ------------------------------------------------------------
>
>                 Key: HBASE-19770
>                 URL: https://issues.apache.org/jira/browse/HBASE-19770
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: Romil Choksi
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19770.001.branch-2.patch, 
> HBASE-19770.002.branch-2.patch
>
>
> Another good find by our Romil.
> {code}
> hbase(main):001:0> list
> TABLE
> a
> 1 row(s)
> Took 0.8385 seconds
> hbase(main):002:0> tables=list
> TABLE
> a
> 1 row(s)
> Took 0.0267 seconds
> hbase(main):003:0> puts tables
> hbase(main):004:0> p tables
> nil
> {code}
> The {{list}} command should be returning {{\['a'\]}} but is not.
> The command class itself appears to be doing the right thing -- maybe the 
> retval is getting lost somewhere else?
> FYI [~stack].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)