[ 
https://issues.apache.org/jira/browse/HBASE-19803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327858#comment-16327858
 ] 

Appy commented on HBASE-19803:
------------------------------

yeah probably, i don't see any unit test calling it (although ITs do). In the 
non -test code, it's mostly main() fn in tools.
But digging around more:
- TestZKMainServer seems to be [handling System.exit() 
appropriately|https://github.com/apache/hbase/blob/master/hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKMainServer.java#L85].
 So do all other tests.
Here's what method: 
https://stackoverflow.com/questions/309396/java-how-to-test-methods-that-call-system-exit
- The only case where it might be wrong is, ImportTsv#createSubmittableJob 
calling System.exit(). TestImportTsv calls that fn multiple times.


> False positive for the HBASE-Find-Flaky-Tests job
> -------------------------------------------------
>
>                 Key: HBASE-19803
>                 URL: https://issues.apache.org/jira/browse/HBASE-19803
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Duo Zhang
>            Priority: Major
>
> It reports two hangs for TestAsyncTableGetMultiThreaded, but I checked the 
> surefire output
> https://builds.apache.org/job/HBASE-Flaky-Tests/24830/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestAsyncTableGetMultiThreaded-output.txt
> This one was likely to be killed in the middle of the run within 20 seconds.
> https://builds.apache.org/job/HBASE-Flaky-Tests/24852/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestAsyncTableGetMultiThreaded-output.txt
> This one was also killed within about 1 minutes.
> The test is declared as LargeTests so the time limit should be 10 minutes. It 
> seems that the jvm may crash during the mvn test run and then we will kill 
> all the running tests and then we may mark some of them as hang which leads 
> to the false positive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to