[ https://issues.apache.org/jira/browse/HBASE-19770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329140#comment-16329140 ]
Josh Elser commented on HBASE-19770: ------------------------------------ bq. gave +1 earlier, feel free to submit whenever you're done with minor changes afa i'm concerned. (just stating it explicitly ) Ok, thanks again, Appy! I have Mike's changes done locally. Will push them up assuming the shell tests pass on master (branch-2 are good). [~andrew.purt...@gmail.com], you OK with this change for branch-1.4? > Add '--return-values' option to Shell to print return values of commands in > interactive mode > -------------------------------------------------------------------------------------------- > > Key: HBASE-19770 > URL: https://issues.apache.org/jira/browse/HBASE-19770 > Project: HBase > Issue Type: Bug > Components: shell > Reporter: Romil Choksi > Assignee: Josh Elser > Priority: Critical > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19770.001.branch-2.patch, > HBASE-19770.002.branch-2.patch, HBASE-19770.003.branch-2.patch > > > Another good find by our Romil. > {code} > hbase(main):001:0> list > TABLE > a > 1 row(s) > Took 0.8385 seconds > hbase(main):002:0> tables=list > TABLE > a > 1 row(s) > Took 0.0267 seconds > hbase(main):003:0> puts tables > hbase(main):004:0> p tables > nil > {code} > The {{list}} command should be returning {{\['a'\]}} but is not. > The command class itself appears to be doing the right thing -- maybe the > retval is getting lost somewhere else? > FYI [~stack]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)