[ https://issues.apache.org/jira/browse/HBASE-19897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348487#comment-16348487 ]
Hadoop QA commented on HBASE-19897: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 9s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 37s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 1s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 9s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m 25s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 32s{color} | {color:green} hbase-client: The patch generated 0 new + 1 unchanged - 3 fixed = 1 total (was 4) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 15s{color} | {color:green} The patch hbase-server passed checkstyle {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 56s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 20m 5s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 2s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}320m 3s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 58s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}367m 51s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.TestNamespace | | | hadoop.hbase.client.TestAsyncTableScan | | | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClient | | | hadoop.hbase.regionserver.wal.TestWALReplay | | | hadoop.hbase.regionserver.TestScannerHeartbeatMessages | | | hadoop.hbase.regionserver.TestHRegionFileSystem | | | hadoop.hbase.quotas.TestSpaceQuotas | | | hadoop.hbase.regionserver.TestCompoundBloomFilter | | | hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient | | | hadoop.hbase.regionserver.TestTags | | | hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports | | | hadoop.hbase.io.encoding.TestEncodedSeekers | | | hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster | | | hadoop.hbase.replication.TestSerialReplication | | | hadoop.hbase.regionserver.TestMobStoreScanner | | | hadoop.hbase.regionserver.TestClearRegionBlockCache | | | hadoop.hbase.mob.compactions.TestMobCompactor | | | hadoop.hbase.replication.TestReplicationStatus | | | hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint | | | hadoop.hbase.trace.TestHTraceHooks | | | hadoop.hbase.TestAcidGuaranteesWithEagerPolicy | | | hadoop.hbase.client.TestRawAsyncTableScan | | | hadoop.hbase.mob.TestExpiredMobFileCleaner | | | hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove | | | hadoop.hbase.regionserver.TestHRegionServerBulkLoadWithOldClient | | | hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation | | | hadoop.hbase.quotas.TestSnapshotQuotaObserverChore | | | hadoop.hbase.regionserver.TestSplitWalDataLoss | | | hadoop.hbase.regionserver.TestEndToEndSplitTransaction | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.replication.TestReplicationKillSlaveRS | | | hadoop.hbase.client.TestMobCloneSnapshotFromClient | | | hadoop.hbase.security.token.TestDelegationTokenWithEncryption | | | hadoop.hbase.replication.TestReplicationEmptyWALRecovery | | | hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove | | | hadoop.hbase.io.hfile.TestCacheOnWrite | | | hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver | | | hadoop.hbase.tool.TestLoadIncrementalHFilesSplitRecovery | | | hadoop.hbase.master.TestMasterFailover | | | hadoop.hbase.master.procedure.TestCloneSnapshotProcedure | | | hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk | | | hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController | | | hadoop.hbase.replication.TestReplicationSource | | | hadoop.hbase.client.TestAsyncTableBatch | | | hadoop.hbase.namespace.TestNamespaceAuditor | | | hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleAsyncWAL | | | hadoop.hbase.regionserver.TestNewVersionBehaviorFromClientSide | | | hadoop.hbase.quotas.TestSuperUserQuotaPermissions | | | hadoop.hbase.TestZooKeeper | | | hadoop.hbase.regionserver.TestRegionReplicaFailover | | | hadoop.hbase.client.TestAsyncResultScannerCursor | | | hadoop.hbase.filter.TestFilterWithScanLimits | | | hadoop.hbase.client.TestFromClientSideNoCodec | | | hadoop.hbase.client.TestScanWithoutFetchingData | | | hadoop.hbase.master.assignment.TestAssignmentOnRSCrash | | | hadoop.hbase.regionserver.TestRegionReplicas | | | hadoop.hbase.tool.TestSecureLoadIncrementalHFiles | | | hadoop.hbase.regionserver.TestRegionFavoredNodes | | | hadoop.hbase.client.TestIncrementFromClientSideWithCoprocessor | | | hadoop.hbase.replication.TestReplicationDroppedTables | | | hadoop.hbase.TestLocalHBaseCluster | | | hadoop.hbase.TestAcidGuaranteesWithNoInMemCompaction | | | hadoop.hbase.client.TestResultScannerCursor | | | hadoop.hbase.client.replication.TestReplicationAdminWithTwoDifferentZKClusters | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | hadoop.hbase.util.TestRegionMover | | | hadoop.hbase.TestAcidGuaranteesWithAdaptivePolicy | | | hadoop.hbase.master.assignment.TestRogueRSAssignment | | | hadoop.hbase.regionserver.TestCompactionInDeadRegionServer | | | hadoop.hbase.client.TestTableFavoredNodes | | | hadoop.hbase.client.TestAdmin2 | | | hadoop.hbase.mob.TestMobDataBlockEncoding | | | hadoop.hbase.regionserver.wal.TestWALReplayCompressed | | | hadoop.hbase.regionserver.TestSettingTimeoutOnBlockingPoint | | | hadoop.hbase.regionserver.TestFlushLifeCycleTracker | | | hadoop.hbase.tool.TestCanaryTool | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.client.TestSnapshotMetadata | | | hadoop.hbase.regionserver.TestRegionServerAbort | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | hadoop.hbase.TestHBaseTestingUtility | | | hadoop.hbase.replication.TestReplicationSyncUpTool | | | hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy | | | hadoop.hbase.procedure.TestFailedProcCleanup | | | hadoop.hbase.TestFullLogReconstruction | | | hadoop.hbase.io.encoding.TestChangingEncoding | | | hadoop.hbase.TestInfoServers | | | hadoop.hbase.quotas.TestSpaceQuotasWithSnapshots | | | hadoop.hbase.regionserver.TestMobStoreCompaction | | | hadoop.hbase.TestAcidGuaranteesWithBasicPolicy | | | hadoop.hbase.util.TestMiniClusterLoadEncoded | | | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.regionserver.TestMajorCompaction | | | hadoop.hbase.replication.regionserver.TestWALEntryStream | | | hadoop.hbase.replication.TestNamespaceReplication | | | hadoop.hbase.client.TestCloneSnapshotFromClientWithRegionReplicas | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | hadoop.hbase.regionserver.TestMutateRowsRecovery | | | hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController | | | hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd | | | hadoop.hbase.replication.TestReplicationKillMasterRSCompressed | | | hadoop.hbase.regionserver.TestClusterId | | | hadoop.hbase.client.TestBlockEvictionFromClient | | | hadoop.hbase.master.TestSplitLogManager | | | hadoop.hbase.client.TestFlushFromClient | | | hadoop.hbase.replication.TestReplicationChangingPeerRegionservers | | | hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleWAL | | | hadoop.hbase.regionserver.TestRegionServerMetrics | | | hadoop.hbase.client.TestSnapshotCloneIndependence | | | hadoop.hbase.client.TestScannersFromClientSide | | | hadoop.hbase.coprocessor.TestRegionObserverInterface | | | hadoop.hbase.security.token.TestZKSecretWatcher | | | hadoop.hbase.client.TestAsyncClusterAdminApi | | | hadoop.hbase.regionserver.wal.TestAsyncLogRolling | | | hadoop.hbase.master.balancer.TestFavoredNodeTableImport | | | hadoop.hbase.security.visibility.TestVisibilityLablesWithGroups | | | hadoop.hbase.TestMetaTableAccessor | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.regionserver.TestRegionReplicasAreDistributed | | | hadoop.hbase.regionserver.TestRegionReplicasWithModifyTable | | | hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | hadoop.hbase.TestIOFencing | | | hadoop.hbase.regionserver.TestFSErrorsExposed | | | hadoop.hbase.regionserver.TestEncryptionRandomKeying | | | hadoop.hbase.client.TestAdmin1 | | | hadoop.hbase.tool.TestLoadIncrementalHFiles | | | hadoop.hbase.client.replication.TestReplicationAdmin | | | hadoop.hbase.client.TestMobSnapshotCloneIndependence | | | hadoop.hbase.replication.TestMasterReplication | | | hadoop.hbase.master.balancer.TestStochasticLoadBalancerLargeCluster | | | hadoop.hbase.coprocessor.TestRegionObserverBypass | | | hadoop.hbase.quotas.TestQuotaObserverChoreWithMiniCluster | | | hadoop.hbase.regionserver.TestPerColumnFamilyFlush | | | hadoop.hbase.coprocessor.TestCoprocessorStop | | | hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleWAL | | | hadoop.hbase.master.assignment.TestRegionStates | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-19897 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12908726/HBASE-19897.v1.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3f437bf3ad49 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 9272f40a5c | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/11311/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11311/testReport/ | | Max. process+thread count | 4453 (vs. ulimit of 10000) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11311/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > RowMutations should follow the fluent pattern > --------------------------------------------- > > Key: HBASE-19897 > URL: https://issues.apache.org/jira/browse/HBASE-19897 > Project: HBase > Issue Type: New Feature > Reporter: Chia-Ping Tsai > Assignee: Chia-Ping Tsai > Priority: Minor > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19897.v0.patch, HBASE-19897.v1.patch > > > Other row ops, including {{Put}}, {{Delete}}, {{Get}}, {{Scan}}, do have the > fluent interface. Also, Changing the return type from {{Void}} to > {{RowMutations}} won't break the API BC (unless someone has interest in > {{Void}} object...) -- This message was sent by Atlassian JIRA (v7.6.3#76005)