[ https://issues.apache.org/jira/browse/HBASE-5074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203040#comment-13203040 ]
Phabricator commented on HBASE-5074: ------------------------------------ tedyu has commented on the revision "[jira] [HBASE-5074] Support checksums in HBase block cache". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/util/ChecksumFactory.java:72 There is no such parameter now. src/main/java/org/apache/hadoop/hbase/util/ChecksumFactory.java:55 Would newConstructor be better name ? This method doesn't really create a new instance. src/main/java/org/apache/hadoop/hbase/util/HFileSystem.java:36 Should read 'An encapsulation' src/main/java/org/apache/hadoop/hbase/util/HFileSystem.java:61 Using this.fs would be cleaner. src/main/java/org/apache/hadoop/hbase/util/HFileSystem.java:122 Can we make the method name and field name consistent in terms of plurality ? REVISION DETAIL https://reviews.facebook.net/D1521 > support checksums in HBase block cache > -------------------------------------- > > Key: HBASE-5074 > URL: https://issues.apache.org/jira/browse/HBASE-5074 > Project: HBase > Issue Type: Improvement > Components: regionserver > Reporter: dhruba borthakur > Assignee: dhruba borthakur > Attachments: D1521.1.patch, D1521.1.patch, D1521.2.patch, > D1521.2.patch, D1521.3.patch, D1521.3.patch, D1521.4.patch, D1521.4.patch > > > The current implementation of HDFS stores the data in one block file and the > metadata(checksum) in another block file. This means that every read into the > HBase block cache actually consumes two disk iops, one to the datafile and > one to the checksum file. This is a major problem for scaling HBase, because > HBase is usually bottlenecked on the number of random disk iops that the > storage-hardware offers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira