[ https://issues.apache.org/jira/browse/HBASE-19917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352021#comment-16352021 ]
Xiang Li commented on HBASE-19917: ---------------------------------- Hi [~yuzhih...@gmail.com], I uploaded patch 000 for branch-1. Please review it at your most convenience. > Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient > --------------------------------------------------------------------- > > Key: HBASE-19917 > URL: https://issues.apache.org/jira/browse/HBASE-19917 > Project: HBase > Issue Type: Improvement > Components: rsgroup > Reporter: Xiang Li > Assignee: Xiang Li > Priority: Minor > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19917.branch-1.000.patch, > HBASE-19917.master.000.patch, HBASE-19917.master.001.patch > > > {code:title=hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java|borderStyle=solid} > private List<ServerName> filterServers(Collection<Address> servers, > Collection<ServerName> onlineServers) { > ArrayList<ServerName> finalList = new ArrayList<ServerName>(); > for (Address server : servers) { > for(ServerName curr: onlineServers) { > if(curr.getAddress().equals(server)) { > finalList.add(curr); > } > } > } > return finalList; > } > {code} > filterServers is to return the union of servers and onlineServers. The > current implementation has time complexity as O(m * n) (2 loops), could be in > O(m + n) if HashSet is used. The trade-off is space complexity is increased. > Another point which could be improved: filterServers() is only called in > filterOfflineServers(). filterOfflineServers calls filterServers(Set, List). > The current filterServers(Collection, Collection) seems could be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)