[
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204943#comment-13204943
]
jirapos...@reviews.apache.org commented on HBASE-5358:
------------------------------------------------------
bq. On 2012-02-09 02:16:29, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java, line
606
bq. > <https://reviews.apache.org/r/3811/diff/2/?file=73392#file73392line606>
bq. >
bq. > Should we validate length ?
It is not validated in other array/list read operations. The allocation will
fail anyway if the length is off, no?
bq. On 2012-02-09 02:16:29, Ted Yu wrote:
bq. > src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java,
line 246
bq. > <https://reviews.apache.org/r/3811/diff/2/?file=73393#file73393line246>
bq. >
bq. > What does InSeq mean ?
Oh, it comes from Seg<T> from Scala, where Array<T> and List<T> extends. I'll
change the method name to testPolymorphismInSequences(), and add some comments,
if you don't have any suggestion.
bq. On 2012-02-09 02:16:29, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java, line
445
bq. > <https://reviews.apache.org/r/3811/diff/2/?file=73392#file73392line445>
bq. >
bq. > What if componentType is another Array ?
The test case for A[][] already covers for this i believe.
- enis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/#review4952
-----------------------------------------------------------
On 2012-02-09 01:38:18, enis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3811/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-09 01:38:18)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[]
where A extends Writable. This becomes an issue for example when adding a
coprocessor method which takes A[] (see HBASE-5352).
bq.
bq.
bq. This addresses bug HBASE-5358.
bq. https://issues.apache.org/jira/browse/HBASE-5358
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
78513ce
bq. src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
260f982
bq.
bq. Diff: https://reviews.apache.org/r/3811/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. enis
bq.
bq.
> HBaseObjectWritable should be able to serialize generic arrays not defined
> previously
> -------------------------------------------------------------------------------------
>
> Key: HBASE-5358
> URL: https://issues.apache.org/jira/browse/HBASE-5358
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors, io
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
>
> HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where
> A extends Writable. This becomes an issue for example when adding a
> coprocessor method which takes A[] (see HBASE-5352).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
