[ 
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205093#comment-13205093
 ] 

Hadoop QA commented on HBASE-5363:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12514046/hbase-5363.2.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -136 warning 
messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 156 new Findbugs (version 
1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.io.hfile.TestHFileBlock

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/933//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/933//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/933//console

This message is automatically generated.
                
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
>                 Key: HBASE-5363
>                 URL: https://issues.apache.org/jira/browse/HBASE-5363
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.90.5, 0.92.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, 
> hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check).  We 
> should add checks likely in the mvn package phase so that this becomes a 
> non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to