[ https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377305#comment-16377305 ]
stack commented on HBASE-20069: ------------------------------- Thanks for helpful review [~chia7712]. Let me see if fb complains about removal of synchronized... will add a by-pass if it does. bq. Is it possible to pass a RegionStateNode carrying null RegionInfo? It seems to me it is like a bug. It should never happen. This check is for FB and if it does happen, we'll have a clean exception. We cannot have WakeupFlushThread be anonymous as whole point of its existence is being able to identify this explicit signaling class. > fix existing findbugs errors in hbase-server > -------------------------------------------- > > Key: HBASE-20069 > URL: https://issues.apache.org/jira/browse/HBASE-20069 > Project: HBase > Issue Type: Sub-task > Components: findbugs > Reporter: Sean Busbey > Assignee: stack > Priority: Critical > Attachments: FindBugs Report.htm, HBASE-20069.branch-2.001.patch, > HBASE-20069.branch-2.002.patch, HBASE-20069.branch-2.003.patch > > > now that findbugs is running on precommit we have some cleanup to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)