[ 
https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205720#comment-13205720
 ] 

Zhihong Yu commented on HBASE-5382:
-----------------------------------

Looks like the patch has been checked in:
{code}
1 out of 1 hunk ignored -- saving rejects to file 
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java.rej
The next patch would create the file 
src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java,
which already exists!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file 
src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java.rej
{code}
I suggest reverting the patch until Hadoop QA can reliably show that 
TestForceCacheImportantBlocks passes.

We already have two consistently failing tests. We don't want to make them 
three.
                
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
>                 Key: HBASE-5382
>                 URL: https://issues.apache.org/jira/browse/HBASE-5382
>             Project: HBase
>          Issue Type: Test
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not 
> committed. The original test was reviewed as part of 
> https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA 
> and patch, and extending the scope of the test to also handle the case when 
> block cache is enabled for the column family. The new review is at 
> https://reviews.facebook.net/D1695.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to