[
https://issues.apache.org/jira/browse/HBASE-20153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393200#comment-16393200
]
Sean Busbey commented on HBASE-20153:
-------------------------------------
We need to alter the "personality_modules" function, it's what tells yetus how
to run particular tests against particular modules (including the degenerate
case of "build everything" that we do in nightly and when there are certain
changes in a patch)
{code}
## @description Queue up modules for this personality
## @audience private
## @stability evolving
## @param repostatus
## @param testtype
function personality_modules
{
{code}
we need to add a stanza that says "if the test type is 'compile' add this extra
maven flag". The closest example I see is a check for doing work when the test
is 'unit'.
{code}
if [[ ${testtype} == unit ]]; then
local tests_arg=""
get_include_exclude_tests_arg tests_arg
extra="${extra} -PrunAllTests ${tests_arg}"
# Inject the jenkins build-id for our surefire invocations
# Used by zombie detection stuff, even though we're not including that yet.
if [ -n "${BUILD_ID}" ]; then
extra="${extra} -Dbuild.id=${BUILD_ID}"
fi
fi
{code}
We don't need all this logic for just adding the error prone profile on
compile, luckily. we'd do something like the specific part where we add in the
"-PrunAllTests".
Let me know if this isn't enough pointers and I'll put up a patch that makes
the change and hopefully provides enough comments that we can rely on it as an
example for the future.
> enable error-prone analysis in precommit
> ----------------------------------------
>
> Key: HBASE-20153
> URL: https://issues.apache.org/jira/browse/HBASE-20153
> Project: HBase
> Issue Type: Bug
> Components: community
> Reporter: Mike Drob
> Priority: Major
>
> We've done a lot of work to get rid of the error-prone errors, we should make
> sure they stay out. Let's enable errorProne profile and analysis in precommit.
> [~busbey] - I tried figuring out how to pass flags ({{-PerrorProne}} to the
> mvn compile precommit check but was unable to unravel that thread. Any help
> is appreciated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
