[ 
https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404092#comment-16404092
 ] 

Christopher Tubbs commented on HBASE-20212:
-------------------------------------------

I haven't benchmarked it, but I'd expect a second compiled "exclude" pattern 
and the extra plugin code needed to process it, to be on par with, or slightly 
worse than any performance hit due to a small lookahead buffer. If there's a 
clear benefit (such as being able to express includes/excludes that aren't 
possible with lookahead syntax, or dramatic simplification of include/exclude 
expressions, or big performance benefit), I'd happily accept a PR, though.

> Make all Public classes have InterfaceAudience category
> -------------------------------------------------------
>
>                 Key: HBASE-20212
>                 URL: https://issues.apache.org/jira/browse/HBASE-20212
>             Project: HBase
>          Issue Type: Task
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Critical
>             Fix For: 2.0.0, 3.0.0, 2.1.0
>
>
> The tasks will be resolved are shown below.
>  # add warbucks-maven-plugin to root pom
>  # make sure all sub modules ref the warbucks-maven-plugin
>  # remove old checker (TestInterfaceAudienceAnnotations)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to