[ https://issues.apache.org/jira/browse/HBASE-20141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424495#comment-16424495 ]
stack commented on HBASE-20141: ------------------------------- Mighty [~zyork]. For the future.... This issue was committed like this: kalashnikov:hbase.git.clean stack$ git show 10a7b5ea15 commit 10a7b5ea1591e93fff39a0c9fc35ee2c8805d49f Author: Zach York <zy...@amazon.com> Date: Wed Feb 28 10:40:38 2018 -0800 [HBASE-20141] Fix TooManyFiles exception when RefreshingChannels HBASE-19435 implements a fix for reopening file channels when they are unnexpected closed to avoid disabling the BucketCache. However, it was missed that the the channels might not actually be completely closed (the write or read channel might still be open (see https://docs.oracle.com/javase/7/docs/api/java/nio/channels/ClosedChannelException.html) This commit closes any open channels before creating a new channel. Don't add the square brackets around the JIRA number going forward. Just an FYI sir (messes up reporting after the fact...no big deal). > Fix TooManyFiles exception when RefreshingChannels in FileIOEngine > ------------------------------------------------------------------ > > Key: HBASE-20141 > URL: https://issues.apache.org/jira/browse/HBASE-20141 > Project: HBase > Issue Type: Bug > Components: BucketCache > Affects Versions: 1.4.0, 2.0.0-beta-1, 1.4.2 > Reporter: Zach York > Assignee: Zach York > Priority: Major > Fix For: 1.5.0, 1.4.3, 2.0.0 > > Attachments: HBASE-20141.master.001.patch, > HBASE-20141.master.002.patch, HBASE-20141.master.003.patch, > HBASE-20141.master.004.patch > > > HBASE-19435 implements a fix for reopening file channels when they are > unnexpected closed > to avoid disabling the BucketCache. However, it was missed that the the > channels might not > actually be completely closed (the write or read channel might still be open > (see > https://docs.oracle.com/javase/7/docs/api/java/nio/channels/ClosedChannelException.html) > This commit closes any open channels before creating a new channel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)