[ https://issues.apache.org/jira/browse/HBASE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209165#comment-13209165 ]
Phabricator commented on HBASE-4422: ------------------------------------ mbautin has committed the revision "[jira] [HBASE-4422] [89-fb] Move block cache parameters and references into single CacheConfig class". REVISION DETAIL https://reviews.facebook.net/D1341 COMMIT https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1239901 > Move block cache parameters and references into single CacheConf class > ---------------------------------------------------------------------- > > Key: HBASE-4422 > URL: https://issues.apache.org/jira/browse/HBASE-4422 > Project: HBase > Issue Type: Improvement > Components: io > Reporter: Jonathan Gray > Assignee: Jonathan Gray > Fix For: 0.92.0 > > Attachments: CacheConfig92-v8.patch, D1341.1.patch, > HBASE-4422-FINAL-branch92.patch, HBASE-4422-FINAL-trunk.patch > > > From StoreFile down to HFile, we currently use a boolean argument for each of > the various block cache configuration parameters that exist. The number of > parameters is going to continue to increase as we look at compressed cache, > delta encoding, and more specific L1/L2 configuration. Every new config > currently requires changing many constructors because it introduces a new > boolean. > We should move everything into a single class so that modifications are much > less disruptive. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira