[ 
https://issues.apache.org/jira/browse/HBASE-18792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437291#comment-16437291
 ] 

Sean Busbey commented on HBASE-18792:
-------------------------------------

{code}
-    if (index < s1.length) {
+    if (index < v1Comps.length) {
       // s1 is longer
       return 1;
     }
{code}

I think this is wrong? like version "2.0.0" should be after "2.0.0-SNAPSHOT". 
it's also after "2.0.0-alpha-3" or "2.0.0-beta-1"

Can we expand the versions checked in {{TestVersionInfo}} to include a) some 
"same major different minor", b) "same minor different maintenance", c) both of 
the above, but SNAPSHOT, d) "-alpha" / "-beta"?

> hbase-2 needs to defend against hbck operations
> -----------------------------------------------
>
>                 Key: HBASE-18792
>                 URL: https://issues.apache.org/jira/browse/HBASE-18792
>             Project: HBase
>          Issue Type: Task
>          Components: hbck
>            Reporter: stack
>            Assignee: Umesh Agashe
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: hbase-18792.master.001.patch
>
>
> hbck needs updating to run against hbase2. Meantime, if an hbck from hbase1 
> is run against hbck2, it may do damage. hbase2 should defend itself against 
> hbck1 ops.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to