[ https://issues.apache.org/jira/browse/HBASE-19850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441271#comment-16441271 ]
Ted Yu commented on HBASE-19850: -------------------------------- When applying the patch to branch-1 using 'git am', I got: {code} Applying: HBASE-19850 The number of Offline Regions is wrong after restoring a snapshot error: patch failed: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java:175 error: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java: patch does not apply error: patch failed: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestRestoreSnapshotFromClient.java:39 error: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestRestoreSnapshotFromClient.java: patch does not apply Patch failed at 0001 HBASE-19850 The number of Offline Regions is wrong after restoring a snapshot The copy of the patch that failed is found in: {code} Can you check ? > The number of Offline Regions is wrong after restoring a snapshot > ----------------------------------------------------------------- > > Key: HBASE-19850 > URL: https://issues.apache.org/jira/browse/HBASE-19850 > Project: HBase > Issue Type: Bug > Components: snapshots > Reporter: Toshihiro Suzuki > Assignee: Toshihiro Suzuki > Priority: Major > Fix For: 1.5.0 > > Attachments: HBASE-19850-branch-1.patch, > HBASE-19850.branch-1.001.patch, HBASE-19850.branch-1.001.patch, The number of > Offline Regions.png > > > Steps to reproduce are as follows: > 1. Create a table > {code:java} > create "test", "cf" > {code} > 2. Take a snapshot for the table > {code:java} > snapshot "test", "snap" > {code} > 3. Load data to the table > {code:java} > (0...2000).each{|i| put "test", "row#{i}", "cf:col", "val"} > {code} > 4. Split regions of the table > {code:java} > split "test" > {code} > 5. Restore the table from the snapshot > {code:java} > disable "test" > restore_snapshot "snap" > enable "test" > {code} > > The number of Offline Regions is as follows: > !The number of Offline Regions.png! > The number of Offline Regions should be zero. > It seems like when regions are removed by restoring a snapshot, the number of > Offline Regions becomes wrong. And as far as I reviewed the code, it seems > like the Offline Regions will not be cleaned up. After restarting Master, the > offline regions disappear. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)