[ https://issues.apache.org/jira/browse/HBASE-20443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Balazs Meszaros updated HBASE-20443: ------------------------------------ Fix Version/s: 3.0.0 Status: Patch Available (was: Open) > Add an HBase antipattern check for reintroducing commons-collections 3 > ---------------------------------------------------------------------- > > Key: HBASE-20443 > URL: https://issues.apache.org/jira/browse/HBASE-20443 > Project: HBase > Issue Type: Task > Components: dependencies, test > Reporter: Sean Busbey > Assignee: Balazs Meszaros > Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20443.master.001.patch > > > we upgraded to commons-collections 4 in HBASE-18704 and then to an > internal-only hbase-thirdparty version in HBASE-20223, but we've regressed: > {code} > $ git grep "import org.apache.commons.collections" > hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java:import > org.apache.commons.collections.MapUtils; > hbase-client/src/main/java/org/apache/hadoop/hbase/client/RowMutations.java:import > org.apache.commons.collections.CollectionUtils; > hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:import > org.apache.commons.collections.CollectionUtils; > hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationQueueStorage.java:import > org.apache.commons.collections.CollectionUtils; > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:import > org.apache.commons.collections.CollectionUtils; > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:import > org.apache.commons.collections.CollectionUtils; > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java:import > org.apache.commons.collections.CollectionUtils; > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java:import > org.apache.commons.collections.CollectionUtils; > hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java:import > org.apache.commons.collections.CollectionUtils; > hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java:import > org.apache.commons.collections.MapUtils; > {code} > we should add the same kind of check as we do for e.g. hadoop annotations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)