[
https://issues.apache.org/jira/browse/HBASE-20441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443100#comment-16443100
]
Mike Drob commented on HBASE-20441:
-----------------------------------
Can we also use this issue to add checks for commons-collection 3 and logging?
The fixes that you're doing in HBASE-20439, HBASE-20440, and HBASE-20442 look
really spiffy.
> Add an HBase antipattern check for reintroducing commons-lang 2
> ---------------------------------------------------------------
>
> Key: HBASE-20441
> URL: https://issues.apache.org/jira/browse/HBASE-20441
> Project: HBase
> Issue Type: Task
> Components: dependencies, test
> Affects Versions: 2.0.0
> Reporter: Sean Busbey
> Priority: Major
> Fix For: 2.0.1
>
>
> We updated to commons-lang 3 in HBASE-18674 but we've regressed:
> {code}
> $ git grep org.apache.commons.lang\\.
> hbase-common/src/main/java/org/apache/hadoop/hbase/net/Address.java:import
> org.apache.commons.lang.StringUtils;
> hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/FileArchiverNotifierFactoryImpl.java:import
> org.apache.commons.lang.builder.HashCodeBuilder;
> hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/FileArchiverNotifierImpl.java:import
> org.apache.commons.lang.builder.HashCodeBuilder;
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHdfsSnapshotHRegion.java:import
> org.apache.commons.lang.StringUtils;
> hbase-server/src/test/java/org/apache/hadoop/hbase/util/compaction/TestMajorCompactionRequest.java:import
> org.apache.commons.lang.RandomStringUtils;
> {code}
> we should add the same kind of check as we do for e.g. hadoop annotations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
