[
https://issues.apache.org/jira/browse/HBASE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210590#comment-13210590
]
stack commented on HBASE-5195:
------------------------------
oops. Its not already in trunk. But my commit to get it into trunk was messy.
I did it in three commits; first a bungled commit that added half which I then
reverted. Then added back. Here is where I made my mess:
{code}
------------------------------------------------------------------------
r1245773 | stack | 2012-02-17 13:34:46 -0800 (Fri, 17 Feb 2012) | 1 line
HBASE-5195 [Coprocessors] preGet hook does not allow overriding or wrapping
filter on incoming Get -- SECOND HALF OF THIS COMMIT
------------------------------------------------------------------------
r1245768 | stack | 2012-02-17 13:26:23 -0800 (Fri, 17 Feb 2012) | 1 line
HBASE-5279 NPE in Master after upgrading to 0.92.0 -- REVERT OVERCOMMIT TO
HREGION
------------------------------------------------------------------------
r1245767 | stack | 2012-02-17 13:24:21 -0800 (Fri, 17 Feb 2012) | 1 line
HBASE-5279 NPE in Master after upgrading to 0.92.0
{code}
r1245767 adds
{code}
@@ -3684,6 +3682,8 @@
}
}
+ Scan scan = new Scan(get);
+
RegionScanner scanner = null;
try {
scanner = getScanner(scan);
{code}
... but not...
{code}
@@ -3673,8 +3673,6 @@
*/
private List<KeyValue> get(Get get, boolean withCoprocessor)
throws IOException {
- Scan scan = new Scan(get);
-
List<KeyValue> results = new ArrayList<KeyValue>();
// pre-get CP hook
{code}
... then r1245768 reverts it because above failed to go in.
Then r1245773 is fixup.
> [Coprocessors] preGet hook does not allow overriding or wrapping filter on
> incoming Get
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5195
> URL: https://issues.apache.org/jira/browse/HBASE-5195
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-5195.patch
>
>
> Without the ability to wrap the internal Scan on the Get, we can't override
> (or protect, in the case of access control) Gets as we can Scans. The result
> is inconsistent behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
