[
https://issues.apache.org/jira/browse/HBASE-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210599#comment-13210599
]
Hadoop QA commented on HBASE-5428:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12515025/ThriftCustomFilters.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -136 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 158 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/983//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/983//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/983//console
This message is automatically generated.
> Allow for custom filters to be registered within the Thrift interface
> ---------------------------------------------------------------------
>
> Key: HBASE-5428
> URL: https://issues.apache.org/jira/browse/HBASE-5428
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.92.0
> Reporter: Robert Roland
> Labels: patch
> Fix For: 0.94.0
>
> Attachments: ThriftCustomFilters.patch
>
>
> Custom filters work within the Java client API, but are not accessible within
> the Thrift API. Attempting to use one will generate a "Filter Name x not
> supported"
> Attached patch allows a user to specify a list of custom filters that are
> registered at Thrift server startup time within the HBase configuration files:
> <property>
> <name>hbase.thrift.filters</name>
> <value>MyFilter:com.foo.Filter,OtherFilter:com.foo.OtherFilter</value>
> </property>
> Patch created off SVN r1245727
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
