[ https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452085#comment-16452085 ]
Hadoop QA commented on HBASE-20478: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 4s{color} | {color:blue} Shelldocs was not available. {color} | | {color:red}-1{color} | {color:red} hbaseanti {color} | {color:red} 0m 0s{color} | {color:red} The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted. {color} | | {color:red}-1{color} | {color:red} hbaseanti {color} | {color:red} 0m 0s{color} | {color:red} The patch appears use Hadoop classification instead of HBase. {color} | | {color:red}-1{color} | {color:red} hbaseanti {color} | {color:red} 0m 0s{color} | {color:red} The patch appears use Jackson 1 classes/annotations. {color} | | {color:red}-1{color} | {color:red} hbaseanti {color} | {color:red} 0m 0s{color} | {color:red} The patch appears to use commons-logging instead of slf4j. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 21s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 25s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 7s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 56s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 8s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 8s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 2m 52s{color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 3m 51s{color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 3m 51s{color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 16s{color} | {color:red} hbase-mapreduce: The patch generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} hbase-backup: The patch generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 35s{color} | {color:red} root: The patch generated 3 new + 31 unchanged - 0 fixed = 34 total (was 31) {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 1s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 3m 51s{color} | {color:red} patch has 40 errors when building our shaded downstream artifacts. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 3s{color} | {color:red} The patch causes 40 errors with Hadoop v2.6.5. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 9s{color} | {color:red} The patch causes 40 errors with Hadoop v2.7.4. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m 27s{color} | {color:red} The patch causes 40 errors with Hadoop v3.0.0. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 21s{color} | {color:red} hbase-mapreduce in the patch failed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 10s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}131m 16s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 59s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}182m 32s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f | | JIRA Issue | HBASE-20478 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12920598/HBASE-20478.WIP.2.patch | | Optional Tests | asflicense shellcheck shelldocs javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5dc78e9ab325 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 12c45cb2e8 | | maven | version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) | | Default Java | 1.8.0_162 | | hbaseanti | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/artifact/patchprocess/patchfile-hbaseanti-results.txt | | shellcheck | v0.4.4 | | findbugs | v3.1.0-RC3 | | mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/artifact/patchprocess/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/artifact/patchprocess/patch-compile-root.txt | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/artifact/patchprocess/patch-compile-root.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/artifact/patchprocess/diff-checkstyle-hbase-mapreduce.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/artifact/patchprocess/diff-checkstyle-hbase-backup.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/artifact/patchprocess/diff-checkstyle-root.txt | | shadedjars | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/artifact/patchprocess/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/artifact/patchprocess/patch-javac-2.6.5.txt | | hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/artifact/patchprocess/patch-javac-2.7.4.txt | | hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/artifact/patchprocess/patch-javac-3.0.0.txt | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/artifact/patchprocess/patch-findbugs-hbase-mapreduce.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/artifact/patchprocess/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/testReport/ | | Max. process+thread count | 4214 (vs. ulimit of 10000) | | modules | C: hbase-mapreduce hbase-backup . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/12629/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > precommit check for "hbase antipatterns" should log details and add a footer > as needed > -------------------------------------------------------------------------------------- > > Key: HBASE-20478 > URL: https://issues.apache.org/jira/browse/HBASE-20478 > Project: HBase > Issue Type: Improvement > Components: test > Reporter: Sean Busbey > Assignee: Sean Busbey > Priority: Major > Attachments: HBASE-20478.0.patch, HBASE-20478.1.patch, > HBASE-20478.2.patch, HBASE-20478.WIP.2.patch, HBASE-20478.WIP.2.patch, > HBASE-20478.WIP.patch > > > came up in discussion on HBASE-20332. our check of "don't do this" things in > the codebase doesn't log the specifics of complaints anywhere, which forces > those who want to follow up to reverse engineer the check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)