[ https://issues.apache.org/jira/browse/HBASE-20475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456321#comment-16456321 ]
Duo Zhang commented on HBASE-20475: ----------------------------------- {code} peersSnapshot = new HashMap<>(); replicationPeers.getPeerCache().forEach(peersSnapshot::put); {code} I think HashMap has a constructor which takes a Map? {code} LOG.warn("Skipping failover for peer:" + actualPeerId + " of node " + deadRS + ", peer is null"); {code} Use '{}' to rewrite the log. Overall LGTM. +1. You can commit and leave the issue open for a while to see if it really works. > Fix the flaky TestReplicationDroppedTables unit test. > ----------------------------------------------------- > > Key: HBASE-20475 > URL: https://issues.apache.org/jira/browse/HBASE-20475 > Project: HBase > Issue Type: Bug > Affects Versions: 2.1.0 > Reporter: Zheng Hu > Assignee: Zheng Hu > Priority: Major > Fix For: 3.0.0, 2.1.0 > > Attachments: HBASE-20475-addendum-v2.patch, > HBASE-20475-addendum-v3.patch, HBASE-20475-addendum.patch, HBASE-20475.patch > > > See > https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)