[ https://issues.apache.org/jira/browse/HBASE-20507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462639#comment-16462639 ]
Ted Yu commented on HBASE-20507: -------------------------------- >From >https://builds.apache.org/job/HBase%20Nightly/job/master/318//JDK8_Nightly_Build_Report_(Hadoop3)/ {code} [ERROR] org.apache.hadoop.hbase.io.asyncfs.TestOverwriteFileUnderConstruction.testOverwrite(org.apache.hadoop.hbase.io.asyncfs.TestOverwriteFileUnderConstruction) [ERROR] Run 1: TestOverwriteFileUnderConstruction.testOverwrite » FileNotFound File does not ... [ERROR] Run 2: TestOverwriteFileUnderConstruction.testOverwrite » FileNotFound File does not ... [ERROR] Run 3: TestOverwriteFileUnderConstruction.testOverwrite » FileNotFound File does not ... {code} > Do not need to call recoverLease on the broken file when we fail to create a > wal writer > --------------------------------------------------------------------------------------- > > Key: HBASE-20507 > URL: https://issues.apache.org/jira/browse/HBASE-20507 > Project: HBase > Issue Type: Improvement > Components: wal > Reporter: Duo Zhang > Assignee: Duo Zhang > Priority: Major > Fix For: 2.1.0, 2.0.1 > > Attachments: HBASE-20507.patch > > > I tried locally with a UT, if we overwrite a file which is currently being > written, the old file will be completed and then deleted. If you call close > on the previous file, a no lease exception will be thrown which means that > the file has already been completed. > So we do not need to close a file if it will be overwritten immediately, > since recoverLease may take a very long time... -- This message was sent by Atlassian JIRA (v7.6.3#76005)