[
https://issues.apache.org/jira/browse/HBASE-20566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473304#comment-16473304
]
Ted Yu edited comment on HBASE-20566 at 5/13/18 12:08 AM:
----------------------------------------------------------
I think the enabling of quota can be done in setUp() method so that we don't
need to restart the cluster twice.
On my Mac, the duration for TestRSGroups went from 182 seconds (with one of the
two restarts in your patch since I moved the enabling of quota to setUp, hence
dropping the first restart) to 166 seconds.
You just need to adjust the assertion in basic test:
{code}
- //3 meta,namespace, group
- assertEquals(3, count);
+ //3 meta,namespace, rsgroup, quota
+ assertEquals(4, count);
{code}
This also proves that all assertions in previous tests still hold with quota
enabled, except for the above one.
was (Author: yuzhih...@gmail.com):
I think the enabling of quota can be done in setUp() method so that we don't
need to restart the cluster twice.
On my Mac, the duration for TestRSGroups went from 182 seconds (with one of the
two restarts in your patch since I moved the enabling of quota to setUp, hence
dropping the first restart) to 166 seconds.
You just need to adjust the assertion in basic test:
{code}
- //3 meta,namespace, group
- assertEquals(3, count);
+ //3 meta,namespace, rsgroup, quota
+ assertEquals(4, count);
{code}
This also proves that all assertions in previous tests still hold with quota
enabled.
> Creating a system table after enabling rsgroup feature puts in region into RIT
> ------------------------------------------------------------------------------
>
> Key: HBASE-20566
> URL: https://issues.apache.org/jira/browse/HBASE-20566
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Biju Nair
> Assignee: Nihal Jain
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20566.master.001.patch
>
>
> *Steps to reproduce*
> - Enable {{rsgroup}} feature
> - Enable {{quota}} feature which created {{hbase::quota}} table
> - quota table region will be marked as RIT since the {{rsgroup}} for the
> table is not known
> {noformat}
> 2018-05-10 14:33:32,392 INFO [ProcedureExecutorThread-0]
> zookeeper.ZKTableStateManager: Moving table hbase:quota state from null to
> ENABLING
> 2018-05-10 14:33:32,397 WARN [ProcedureExecutorThread-0]
> rsgroup.RSGroupBasedLoadBalancer: Group for table hbase:quota is null
> 2018-05-10 14:33:32,398 WARN [ProcedureExecutorThread-0]
> master.RegionStates: Failed to open/close 89490cd5e00ea8948af413a1df65091a on
> null, set to FAILED_OPEN
> 2018-05-10 14:33:32,398 INFO [ProcedureExecutorThread-0]
> master.RegionStates: Transition {89490cd5e00ea8948af413a1df65091a
> state=OFFLINE, ts=1525977212397, server=null} to
> {89490cd5e00ea8948af413a1df65091a state=FAILED_OPEN, ts=1525977212398,
> server=null}
> 2018-05-10 14:33:32,398 INFO [ProcedureExecutorThread-0]
> zookeeper.ZKTableStateManager: Moving table hbase:quota state from ENABLING
> to ENABLED
> {noformat}
> - Reason for this issue: Issue
> - [system table
> creation|https://github.com/apache/hbase/blob/061a31fad1654d9ded96d118e04c14860413fa25/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1793]
> doesn't move the table to the appropriate rs group to which system namespace
> is assigned to. Need to execute logic similar to what is done in the
> RSGroupAdminEndpoint for [post table creation|#L377] for user table creation.
> *Work Around*
> - Assigning the system table to ``default`` rsgroup (or to the rsgroup to
> which the system namespace has been assigned).
> - Manually assigning the region in RIT from the system table
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
