[ https://issues.apache.org/jira/browse/HBASE-20627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487909#comment-16487909 ]
Ted Yu commented on HBASE-20627: -------------------------------- Added TestRSGroups$CPMasterObserver in v2. However, the two hooks are not called - with or without patch v1. Debugging. > Relocate RS Group pre/post hooks from RSGroupAdminServer to > RSGroupAdminEndpoint > -------------------------------------------------------------------------------- > > Key: HBASE-20627 > URL: https://issues.apache.org/jira/browse/HBASE-20627 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Priority: Major > Attachments: 20627.v1.txt, 20627.v2.txt > > > Currently RS Group pre/post hooks are called from RSGroupAdminServer. > e.g. RSGroupAdminServer#removeRSGroup : > {code} > if (master.getMasterCoprocessorHost() != null) { > master.getMasterCoprocessorHost().preRemoveRSGroup(name); > } > {code} > RSGroupAdminServer#removeRSGroup is called by RSGroupAdminEndpoint : > {code} > checkPermission("removeRSGroup"); > groupAdminServer.removeRSGroup(request.getRSGroupName()); > {code} > If permission check fails, the pre hook wouldn't be called. -- This message was sent by Atlassian JIRA (v7.6.3#76005)