[ 
https://issues.apache.org/jira/browse/HBASE-5351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213220#comment-13213220
 ] 

Hadoop QA commented on HBASE-5351:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12515521/HBASE-5351.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -134 warning 
messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 159 new Findbugs (version 
1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestSplitLogManager
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1002//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1002//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1002//console

This message is automatically generated.
                
> hbase completebulkload to a new table fails in a race
> -----------------------------------------------------
>
>                 Key: HBASE-5351
>                 URL: https://issues.apache.org/jira/browse/HBASE-5351
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 0.94.0, 0.92.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>         Attachments: HBASE-5351.patch
>
>
> I have a test that tests vanilla use of importtsv with importtsv.bulk.output 
> option followed by completebulkload to a new table.
> This sometimes fails as follows:
> 11/12/19 15:02:39 WARN client.HConnectionManager$HConnectionImplementation: 
> Encountered problems when prefetch META table:
> org.apache.hadoop.hbase.TableNotFoundException: Cannot find row in .META. for 
> table: ml_items_copy, row=ml_items_copy,,99999999999999
> at org.apache.hadoop.hbase.client.MetaScanner.metaScan(MetaScanner.java:157)
> at org.apache.hadoop.hbase.client.MetaScanner.access$000(MetaScanner.java:52)
> at org.apache.hadoop.hbase.client.MetaScanner$1.connect(MetaScanner.java:130)
> at org.apache.hadoop.hbase.client.MetaScanner$1.connect(MetaScanner.java:127)
> at 
> org.apache.hadoop.hbase.client.HConnectionManager.execute(HConnectionManager.java:359)
> at org.apache.hadoop.hbase.client.MetaScanner.metaScan(MetaScanner.java:127)
> at org.apache.hadoop.hbase.client.MetaScanner.metaScan(MetaScanner.java:103)
> at 
> org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.prefetchRegionCache(HConnectionManager.java:875)
> at 
> org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegionInMeta(HConnectionManager.java:929)
> at 
> org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:817)
> at 
> org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:781)
> at org.apache.hadoop.hbase.client.HTable.finishSetup(HTable.java:247)
> at org.apache.hadoop.hbase.client.HTable.<init>(HTable.java:211)
> at org.apache.hadoop.hbase.client.HTable.<init>(HTable.java:171)
> at 
> org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.createTable(LoadIncrementalHFiles.java:673)
> at 
> org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:697)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:69)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:83)
> at 
> org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:707)
> The race appears to be calling HbAdmin.createTableAsync(htd, keys) and then 
> creating an HTable object before that call has actually completed.
> The following change to 
> /src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java 
> appears to fix the problem, but I have not been able to reproduce the race 
> reliably, in order to write a test.
> {code}
> -    HTable table = new HTable(this.cfg, tableName);
> -
> -    HConnection conn = table.getConnection();
>      int ctr = 0;
> -    while (!conn.isTableAvailable(table.getTableName()) && 
> (ctr<TABLE_CREATE_MA
> +    while (!this.hbAdmin.isTableAvailable(tableName) && 
> (ctr<TABLE_CREATE_MAX_R
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to