[ https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213239#comment-13213239 ]
Hadoop QA commented on HBASE-5357: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515534/Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 78 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -136 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 159 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestWideScanner Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1004//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1004//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1004//console This message is automatically generated. > Use builder pattern in HColumnDescriptor > ---------------------------------------- > > Key: HBASE-5357 > URL: https://issues.apache.org/jira/browse/HBASE-5357 > Project: HBase > Issue Type: Improvement > Reporter: Mikhail Bautin > Assignee: Mikhail Bautin > Attachments: D1851.1.patch, > Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch > > > We have five ways to create an HFile writer, two ways to create a StoreFile > writer, and the sets of parameters keep changing, creating a lot of > confusion, especially when porting patches across branches. The same thing is > happening to HColumnDescriptor. I think we should move to a "builder pattern" > solution, e.g. > {code:java} > HFileWriter w = HFile.getWriterBuilder(conf, <some common args>) > .setParameter1(value1) > .setParameter2(value2) > ... > .build(); > {code} > Each parameter setter being on its own line will make merges/cherry-pick work > properly, we will not have to even mention default parameters again, and we > can eliminate a dozen impossible-to-remember constructors. > This particular JIRA addresses the HColumnDescriptor refactoring. For > StoreFile/HFile refactoring see HBASE-5442. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira