[
https://issues.apache.org/jira/browse/HBASE-4991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213399#comment-13213399
]
stack commented on HBASE-4991:
------------------------------
@Mubarak
Do we need to add this method to the region server interface?
{code}
+ public int getRegionsCount(byte[] regionName) throws IOException;
{code}
Can we not just count what comes back from the get on online regions?
Do we have to run the region delete in the Master process? Can the client not
do it?
Is it really necessary adding + public MasterDeleteRegionTracker
getDeleteRegionTracker(); to the MasterServices? This will have a ripple
effect through Tests and it seems like a bit of an exotic API to have in this
basic Interface.
I like the refactor in HRegion.
Does all of this new code need to be in HRegionServer? Can it live in a class
of its own?
There must be a million holes here (HRS crashes in middle of file moving or
creation of the merged region, files partially moved or deleted....).
Does this code all need to be in core? Can we not make a few primitives and
then run it all from outside in a tool or script w/ state recorded as we go so
can resume if fail mid-way? There are a bunch of moving pieces here. Its all
bundled up in core code so its going to be tough to test.
Adding this to onlineregions, + public void deleteRegion(String regionName)
throws IOException, KeeperException;, do all removals from online regions now
use this new API (Its probably good having it here... but just wondering about
the places where regions currently get removed from online map, do they go a
different route than this new one?)
Hmmmm... looks like a bunch of state is being tracked in zk. Thats good. Its
all custom to this feature. How hard will it be to reuse parts to do say an
online merge of a bunch of adjacent regions?
Yeah, there is a lot of moving parts... a master delete tracker and a
regionserver delete tracker... I've not done an extensive review of design but
that seems pretty heavy going.
Are the enums duplicated?
Why does zookeeper package have classes particular to master and regionserver?
> Provide capability to delete named region
> -----------------------------------------
>
> Key: HBASE-4991
> URL: https://issues.apache.org/jira/browse/HBASE-4991
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Mubarak Seyed
> Fix For: 0.94.0
>
> Attachments: HBASE-4991.trunk.v1.patch, HBASE-4991.trunk.v2.patch
>
>
> See discussion titled 'Able to control routing to Solr shards or not' on
> lily-discuss
> User may want to quickly dispose of out of date records by deleting specific
> regions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
