[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492791#comment-16492791 ]
Hadoop QA commented on HBASE-20656: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 36s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 29s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 4m 48s{color} | {color:blue} branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 50s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 53s{color} | {color:blue} hbase-server in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 58s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m 51s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 59s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 29s{color} | {color:red} root: The patch generated 14 new + 2 unchanged - 5 fixed = 16 total (was 7) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 4m 49s{color} | {color:blue} patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. {color} | | {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 3m 29s{color} | {color:red} patch has 15 errors when building our shaded downstream artifacts. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 56s{color} | {color:red} The patch causes 15 errors with Hadoop v2.6.5. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 50s{color} | {color:red} The patch causes 15 errors with Hadoop v2.7.4. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 47s{color} | {color:red} The patch causes 15 errors with Hadoop v3.0.0. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 5s{color} | {color:red} hbase-server generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 58s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 11m 6s{color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 20s{color} | {color:red} The patch generated 1 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 71m 40s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.tool.coprocessor.CoprocessorValidator.doWork() creates a org.apache.hadoop.hbase.tool.coprocessor.CoprocessorValidator$ResolverUrlClassLoader classloader, which should be performed within a doPrivileged block At CoprocessorValidator.java:which should be performed within a doPrivileged block At CoprocessorValidator.java:[line 201] | | | org.apache.hadoop.hbase.tool.coprocessor.CoprocessorValidator.validate(List, List) creates a org.apache.hadoop.hbase.tool.coprocessor.CoprocessorValidator$ResolverUrlClassLoader classloader, which should be performed within a doPrivileged block At CoprocessorValidator.java:classloader, which should be performed within a doPrivileged block At CoprocessorValidator.java:[line 117] | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f | | JIRA Issue | HBASE-20656 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12925436/HBASE-20656.master.001.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide | | uname | Linux fd4f77cb003c 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 1cd2b56802 | | maven | version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) | | Default Java | 1.8.0_171 | | refguide | https://builds.apache.org/job/PreCommit-HBASE-Build/12984/artifact/patchprocess/branch-site/book.html | | findbugs | v3.1.0-RC3 | | mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/12984/artifact/patchprocess/patch-mvninstall-root.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/12984/artifact/patchprocess/diff-checkstyle-root.txt | | refguide | https://builds.apache.org/job/PreCommit-HBASE-Build/12984/artifact/patchprocess/patch-site/book.html | | shadedjars | https://builds.apache.org/job/PreCommit-HBASE-Build/12984/artifact/patchprocess/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/12984/artifact/patchprocess/patch-javac-2.6.5.txt | | hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/12984/artifact/patchprocess/patch-javac-2.7.4.txt | | hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/12984/artifact/patchprocess/patch-javac-3.0.0.txt | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/12984/artifact/patchprocess/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/12984/artifact/patchprocess/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/12984/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-HBASE-Build/12984/artifact/patchprocess/patch-asflicense-problems.txt | | Max. process+thread count | 289 (vs. ulimit of 10000) | | modules | C: hbase-server . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/12984/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Validate pre-2.0 coprocessors against HBase 2.0+ > ------------------------------------------------ > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling > Affects Versions: 3.0.0 > Reporter: Balazs Meszaros > Assignee: Balazs Meszaros > Priority: Major > Attachments: HBASE-20656.master.001.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)