[
https://issues.apache.org/jira/browse/HBASE-5433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213414#comment-13213414
]
Hadoop QA commented on HBASE-5433:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12515299/HBASE-5433.trunk.v1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -136 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 159 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/1005//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/1005//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1005//console
This message is automatically generated.
> [REST] Add metrics to keep track of success/failure count
> ---------------------------------------------------------
>
> Key: HBASE-5433
> URL: https://issues.apache.org/jira/browse/HBASE-5433
> Project: HBase
> Issue Type: Improvement
> Components: metrics, rest
> Affects Versions: 0.94.0
> Reporter: Mubarak Seyed
> Assignee: Mubarak Seyed
> Labels: noob
> Fix For: 0.94.0
>
> Attachments: HBASE-5433.trunk.v1.patch
>
>
> In a production environment, the visibility of successful REST request(s) are
> not getting exposed to metric system as we have only one metric (requests)
> today.
> Proposing to add more metrics such as successful_get_count, failed_get_count,
> successful_put_count, failed_put_count
> The current implementation increases the request count at the beginning of
> the method implementation and it is very hard to monitor requests (unless
> turn on debug, find the row_key and validate it in get/scan using hbase
> shell), it will be very useful to ops to keep an eye as requests from cross
> data-centers are trying to write data to one cluster using REST gateway
> through load balancer (and there is no visibility of which REST-server/RS
> failed to write data)
> {code}
> Response update(final CellSetModel model, final boolean replace) {
> // for requests
> servlet.getMetrics().incrementRequests(1);
> ..
> ..
> table.put(puts);
> table.flushCommits();
> ResponseBuilder response = Response.ok();
> // for successful_get_count
> servlet.getMetrics().incrementSuccessfulGetRequests(1);
> return response.build();
> } catch (IOException e) {
> // for failed_get_count
> servlet.getMetrics().incrementFailedGetRequests(1);
> throw new WebApplicationException(e,
> Response.Status.SERVICE_UNAVAILABLE);
> } finally {
> }
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
