[ https://issues.apache.org/jira/browse/HBASE-20707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508851#comment-16508851 ]
Hudson commented on HBASE-20707: -------------------------------- Results for branch branch-2 [build #851 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/851/]: (/) *{color:green}+1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/851//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/851//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/851//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > Move MissingSwitchDefault check from checkstyle to error-prone > -------------------------------------------------------------- > > Key: HBASE-20707 > URL: https://issues.apache.org/jira/browse/HBASE-20707 > Project: HBase > Issue Type: Bug > Components: build > Reporter: Mike Drob > Assignee: Mike Drob > Priority: Major > Fix For: 3.0.0, 2.1.0 > > Attachments: HBASE-20707.patch > > > Both checkstyle and error-prone can alert when a switch statement is missing > a default. However, because checkstyle does it via static analysis and > error-prone does it during compilation, e-p can detect when all cases of an > enum have been covered, and will _not_ warn about the needed default case. > In fact, checkstyle explicitly mentions in their docs that even if you cover > all enum cases now, you should still have a default label because the enum > could change in the future. Which seems silly to me, because your analysis > tools should still be running in the future and would catch it then. > Se we should migrate the check from checkstyle to a slightly smarter > error-prone check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)