[ 
https://issues.apache.org/jira/browse/HBASE-20674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509079#comment-16509079
 ] 

Sean Busbey commented on HBASE-20674:
-------------------------------------

looks like Surefire recognized that it failed ([log from running unit 
tests|https://builds.apache.org/job/PreCommit-HBASE-Build/13195/artifact/patchprocess/patch-unit-root.txt]):

{code}
[ERROR] Errors: 
[ERROR]   
TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL>TestReplicationKillMasterRS.killOneMasterRS:40->TestReplicationKillRS.loadTableAndKillRS:70
 » RetriesExhausted
[INFO] 
{code}

But as you mentioned [Jenkins JUnit reporter couldn't parse the 
results|https://builds.apache.org/job/PreCommit-HBASE-Build/13195/testReport/TEST-org.apache.hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL/xml/_failed_to_read_/]:

{code}
Failed to read test report file 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/hbase-server/target/surefire-reports/TEST-org.apache.hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL.xml
org.dom4j.DocumentException: Error on line 80 of document  : XML document 
structures must start and end within the same entity. Nested exception: XML 
document structures must start and end within the same entity.
{code}

If you browse to [the {{artifact/patchprocess}} directory for the 
build|https://builds.apache.org/job/PreCommit-HBASE-Build/13195/artifact/patchprocess/]
 there'll be a [file with all the surefire results zipped up named 
'test_logs.zip'|https://builds.apache.org/job/PreCommit-HBASE-Build/13195/artifact/patchprocess/test_logs.zip].

{code}
$ find . -name *TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL*
./component/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL-output.txt
./component/hbase-server/target/surefire-reports/TEST-org.apache.hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL.xml
./component/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL.txt
{code}

The xml file in question appears truncated. It just ends after opening the 
CDATA block for stderr of the test.

The other files contain stuff, but glancing at them didn't reveal anything 
obvious.

Hopefully that helps for pointers? It doesn't look like a bug in precommit, 
FWIW. maybe surefire.


> clean up short circuit read logic and docs
> ------------------------------------------
>
>                 Key: HBASE-20674
>                 URL: https://issues.apache.org/jira/browse/HBASE-20674
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>            Priority: Major
>         Attachments: HBASE-20674.patch, HBASE-20674.v2.patch, 
> HBASE-20674.v3.patch, HBASE-20674.v4.patch, HBASE-20674.v5.patch
>
>
> Mailing list discussion at 
> https://lists.apache.org/thread.html/f6f73df0ceae29f762f9b9088e3ffd0bf8f109d3dd692df100bf4fd6@%3Cdev.hbase.apache.org%3E
> There are several inconsistencies between how our docs claim we do things and 
> how we actually do things.
> There are two docs sections that attempt to address how SCR should work.
> dfs.client.read.shortcircuit.skip.checksum is advised to set to true, but our 
> code in separate places ignores it and then later sets it to true anyway.
> CommonFSUtils and FSUtils duplicate code related to SCR setup.
> There is a workaround in HFileSystem for a bug that's been fixed in all 
> versions of hadoop that we support. (HADOOP-9307)
> We suggest setting dfs.client.read.shortcircuit.buffer.size to a value that 
> is very close to what we'd set it to anyway, without clearly explaining why 
> this is important.
> There are other properties that we claim are important, but we don't offer 
> any suggestions or explanations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to