[
https://issues.apache.org/jira/browse/HBASE-20695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510701#comment-16510701
]
Xu Cang commented on HBASE-20695:
---------------------------------
{quote}Assert.assertNotEquals(0, msr.getLastShippedAge());
{quote}
assertEquals 123?
Xu: changed. thanks.
{quote}private Map<String, MetricsReplicationSourceSource>
singleSourceSourceByTable;
{quote}
Concurrent map? Do write same table by different shipper thread?
Xu: I could not see this class is been used in multithread scenarios. And also
see this "lastTimestamps" in the same class, which is not been guarded by
thread-safe data structure either. Please correct me if I missed something.
thank you!
> Implement table level RegionServer replication metrics
> -------------------------------------------------------
>
> Key: HBASE-20695
> URL: https://issues.apache.org/jira/browse/HBASE-20695
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Xu Cang
> Assignee: Xu Cang
> Priority: Minor
> Attachments: HBASE-20695.master.001.patch,
> HBASE-20695.master.002.patch, HBASE-20695.master.003.patch,
> HBASE-20695.master.004.patch, HBASE-20695.master.005.patch,
> HBASE-20695.master.006.patch, HBASE-20695.master.007.patch
>
>
> Region server metrics now are mainly global metrics. It would be nice to have
> table level metrics such as table level source.AgeOfLastShippedOp to indicate
> operators which table's replication is lagging behind.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
