[
https://issues.apache.org/jira/browse/HBASE-20732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519241#comment-16519241
]
Reid Chan edited comment on HBASE-20732 at 6/21/18 11:29 AM:
-------------------------------------------------------------
Simplified {{TestCleanChore}}.
ps, two methods,
{{TestCleanChore#testCleanerDoesNotDeleteDirectoryWithLateAddedFiles}} and
{{TestCleanChore#testNoExceptionFromDirectoryWithRacyChildren}} almost the
same, but results was different on below assertion on local test,
{code}Mockito.verify(spy,
Mockito.times(1)).isFileDeletable(Mockito.any());{code}
The former was 2, the latter was 1.
Waiting QA.
was (Author: reidchan):
SimplifiedTestCleanChore}}.
ps, two methods,
{{TestCleanChore#testCleanerDoesNotDeleteDirectoryWithLateAddedFiles}} and
{{TestCleanChore#testNoExceptionFromDirectoryWithRacyChildren}} almost the
same, but results was different on below assertion on local test,
{code}Mockito.verify(spy,
Mockito.times(1)).isFileDeletable(Mockito.any());{code}
The former was 2, the latter was 1.
Waiting QA.
> Shutdown scan pool when master is stopped.
> ------------------------------------------
>
> Key: HBASE-20732
> URL: https://issues.apache.org/jira/browse/HBASE-20732
> Project: HBase
> Issue Type: Bug
> Reporter: Reid Chan
> Assignee: Reid Chan
> Priority: Minor
> Attachments: HBASE-20732.master.001.patch,
> HBASE-20732.master.002.patch, HBASE-20732.master.003.patch,
> HBASE-20732.master.004.patch
>
>
> If master is stopped, {{DirScanPool}} is kept open. This is found by
> [~chia7712] when reviewing HBASE-20352.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
