[
https://issues.apache.org/jira/browse/HBASE-20732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520105#comment-16520105
]
Reid Chan commented on HBASE-20732:
-----------------------------------
{quote}
alwaysDelete.isFileDeletable(<any>); Wanted 1 time: -> at
org.apache.hadoop.hbase.master.cleaner.TestCleanerChore.testNoExceptionFromDirectoryWithRacyChildren(TestCleanerChore.java:348)
But was 2 times. Undesired invocation: -> at
org.apache.hbase.thirdparty.com.google.common.collect.Iterators$4.computeNext(Iterators.java:624)
at
org.apache.hadoop.hbase.master.cleaner.TestCleanerChore.testNoExceptionFromDirectoryWithRacyChildren(TestCleanerChore.java:348)
{quote}
It is caused by unclean test-dir.
V5 patch
* addresses Chia-Ping's Q1
* better deals with null case
* adds Nullable annotations on method #getFilteredStatus
* improves code readability in {{CleanerChore.class}}
* removes some chatty logs, or move them to TRACE level.
Test passed on local 10+ times. Waiting QA.
> Shutdown scan pool when master is stopped.
> ------------------------------------------
>
> Key: HBASE-20732
> URL: https://issues.apache.org/jira/browse/HBASE-20732
> Project: HBase
> Issue Type: Bug
> Reporter: Reid Chan
> Assignee: Reid Chan
> Priority: Minor
> Attachments: HBASE-20732.master.001.patch,
> HBASE-20732.master.002.patch, HBASE-20732.master.003.patch,
> HBASE-20732.master.004.patch, HBASE-20732.master.005.patch
>
>
> If master is stopped, {{DirScanPool}} is kept open. This is found by
> [~chia7712] when reviewing HBASE-20352.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
